Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Review test coverage #171

Closed
slaweet opened this issue May 3, 2017 · 1 comment
Closed

Review test coverage #171

slaweet opened this issue May 3, 2017 · 1 comment
Assignees
@slaweet
Labels
*hard test
Milestone
Version 1.0.0

Comments

@slaweet
Copy link
Contributor

slaweet commented May 3, 2017

Go through the test coverage report and unit tests where they are missing and it's possible to easily test it. I'm sure there are many such places after all the changes we've made in 1.0.0 project.
@slaweet slaweet added this to the Version 1.0.0 milestone May 3, 2017
@slaweet
Copy link
Contributor Author

slaweet commented May 4, 2017

Part of this issue should be also to make sure that each test file contains exactly one top-level describe statement.
Currently, some contain two, e.g. forging.spec.js:

  • Forging component
  • forging component controller

@slaweet slaweet self-assigned this May 4, 2017
@slaweet slaweet changed the title Review code coverage Review test coverage May 4, 2017
@slaweet slaweet mentioned this issue May 8, 2017
Merged
karmacoma added a commit that referenced this issue May 8, 2017
@karmacoma
Merge pull request #185 from LiskHQ/171_test-coverage-review
228dcec 
Review test coverage - Closes #171
@snyk-bot snyk-bot mentioned this issue Sep 23, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jan 18, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@slaweet slaweet

Labels
*hard test
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
1 participant
@slaweet