Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Prevent regular login with non-bip39-passphrase and ENTER-key #112

Closed
simonmorgenthaler opened this issue Apr 13, 2017 · 0 comments
Closed

Comments

@simonmorgenthaler
Copy link

Currently you can login with any passphrase/password (even with no passphrase at all) when you press ENTER instead of clicking the Login-Button. This should be prevented because it will confuse people which mistype their passphrase and gets logged in into a complete different account.

Expected behaviour

Login for the regular/average user should be only possible with a bip39-passphrase, independently from using the ENTER-key or clicking the Login Button.
Maybe it should be possible for experienced users to login also with any passphrase.

Actual behaviour

Average user gets logged in with any passphrase if he presses ENTER

Steps to reproduce

Enter any text and press ENTER

Possible solution

Possible solutions to prevent login for average users with wrong passwords, but allow experienced users to use it anyways:

  1. Add a dropdown or checkbox called "Allow login with non-standard passphrase (not recommended, only for experienced users)"
  2. Popup that says "You entered an unusual password, which is probably a mistake. Do you want to login anyways?"
@karmacoma karmacoma changed the title prevent regular Login with non-bip39-passphrase and ENTER-key Prevent regular login with non-bip39-passphrase and ENTER-key Apr 13, 2017
@karmacoma karmacoma added the bug label Apr 13, 2017
@slaweet slaweet self-assigned this Apr 18, 2017
@slaweet slaweet added the *easy label Apr 18, 2017
karmacoma added a commit that referenced this issue Apr 18, 2017
Prevent regular login with non-bip39-passphrase and ENTER-key - Closes #112
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants