Refetch transactions only if there are some recent ones

LiskArchive · Sep 14, 2017 · 6d5e7a8 · 6d5e7a8
1 parent 2da347e
commit 6d5e7a8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/src/store/middlewares/account.js b/src/store/middlewares/account.js
@@ -17,11 +17,17 @@ const updateTransactions = (store, peers, account) => {
     })));
 };
 
+const hasRecentTransactions = state => (
+  state.transactions.confirmed.filter(tx => tx.confirmations < 1000).length !== 0 ||
+  state.transactions.pending.length !== 0
+);
+
 const updateAccountData = (store, action) => { // eslint-disable-line
-  const { peers, account } = store.getState();
+  const state = store.getState();
+  const { peers, account } = state;
 
   getAccount(peers.data, account.address).then((result) => {
-    if (action.data.interval === SYNC_ACTIVE_INTERVAL) {
+    if (action.data.interval === SYNC_ACTIVE_INTERVAL && hasRecentTransactions(state)) {
       updateTransactions(store, peers, account);
     }
     if (result.balance !== account.balance) {

diff --git a/src/store/middlewares/account.test.js b/src/store/middlewares/account.test.js
@@ -48,6 +48,12 @@ describe('Account middleware', () => {
       account: {
         balance: 0,
       },
+      transactions: {
+        pending: [{
+          id: 12498250891724098,
+        }],
+        confirmed: [],
+      },
     };
     store.getState = () => (state);
 
@@ -103,7 +109,7 @@ describe('Account middleware', () => {
     // expect(stubTransactions).to.have.been.calledWith();
   });
 
-  it(`should call transactions API methods on ${actionTypes.metronomeBeat} action if action.data.interval is SYNC_ACTIVE_INTERVAL`, () => {
+  it(`should call transactions API methods on ${actionTypes.metronomeBeat} action if action.data.interval is SYNC_ACTIVE_INTERVAL and there are recent transactions`, () => {
     stubGetAccount.resolves({ balance: 0 });
 
     middleware(store)(next)(activeBeatAction);