Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Fee for optional data - Closes #146 #147

Closed
wants to merge 10 commits into from
Closed

Fee for optional data - Closes #146 #147

wants to merge 10 commits into from

Conversation

toschdev
Copy link
Contributor

@toschdev toschdev commented Jul 3, 2017 •
edited
Loading

Closes #146

This PR also contains changes as mentioned in LiskArchive/lisk-sdk#26 (comment)

@toschdev toschdev changed the base branch from development to 1.0.0 July 3, 2017 11:42
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 99.188% when pulling 6db0dc8 on 146-fee-for-optional-data into 9d9938d on 1.0.0.

@toschdev toschdev requested a review from SargeKhan July 3, 2017 12:00
@toschdev toschdev added this to the Version 1.0.0 milestone Jul 6, 2017
@toschdev toschdev self-assigned this Jul 6, 2017
@karmacoma karmacoma modified the milestone: Version 1.0.0 Jul 10, 2017
SargeKhan
SargeKhan suggested changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@SargeKhan SargeKhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make corresponding changes in lib/transactions/utils for updating size of the asset in case data property is set for SEND transactions and the increased fee if the property exists.

@Isabello Isabello closed this Jul 24, 2017
@diego-G diego-G mentioned this pull request Jul 24, 2017
Merged
@toschdev toschdev deleted the 146-fee-for-optional-data branch August 18, 2017 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SargeKhan SargeKhan SargeKhan requested changes

Assignees

@toschdev toschdev

Labels
🗑️ invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@toschdev @coveralls @SargeKhan @karmacoma @willclarktech @Isabello @alepop