Add support for static storage container name #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on the backend used, we might need a static container name. In a scenario of ceph-driver this corresponds to a ceph pool that holds the backups, which is not something the user can create themselves thru Openstack Cinder.
|
Hello @Jonher937, That sounds good. Give me some time to run quick test and reach back to you. |
|
Hey, I had to release a fix for CI and synced this branch. If the CI runs fine I can merge the PR. |
|
Thanks for the quick merge and maintaining this plugin ⭐ |
|
Thank you for contribution. New tag was published successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a storage backend such as ceph block, the
containercorresponds to aceph pooland is not managed by the user, but rather by the storage/Openstack operator.In a S3 deployment it's fine for this to be dynamic as it's managed by the user, but in some cases (such as ceph block) the user needs to be able to override this
containervalue.With this change I was able to point to our
backupspools, same pool as what Openstack Cinder Backup is using.