Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infobox): do not show accomodation button based on exception list #5002

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

hjpalpha
Copy link
Collaborator

@hjpalpha hjpalpha commented Nov 1, 2024

so far only as an idea for discussion on admin discord

Summary

add exception list support for the accomodation button

  • json in mediawiki namespace and hence can only be edited by admins (to avoid misusage)
  • supresses the display for these cases
  • reason: events could not allow crowds, imo we should have an option to not display the button for those

How did you test this change?

dev

- esxception list as json in mediawiki namespace
- hence can only be edited by admins
@hjpalpha hjpalpha changed the title [discussion] feat(infobox): do not show accomodation button for finished events or if no crowd is allowed [discussion] feat(infobox): do not show accomodation button based on exception list Nov 5, 2024
@hjpalpha hjpalpha requested a review from Rathoz November 5, 2024 12:21
@hjpalpha hjpalpha changed the title [discussion] feat(infobox): do not show accomodation button based on exception list feat(infobox): do not show accomodation button based on exception list Nov 5, 2024
@hjpalpha hjpalpha marked this pull request as ready for review November 5, 2024 12:21
@iMarbot
Copy link
Collaborator

iMarbot commented Nov 9, 2024

Could we not just have a default empty json list on commons to avoid the Page.exists('MediaWiki:AccomodationExclusionList.json') or does mw.loadJsonData not support commons?

@hjpalpha
Copy link
Collaborator Author

hjpalpha commented Nov 9, 2024

Could we not just have a default empty json list on commons to avoid the Page.exists('MediaWiki:AccomodationExclusionList.json') or does mw.loadJsonData not support commons?

yeah sadly can't load the json from commons

reason why i didn't use a data module is that we would have to lock down the page on each wiki (against editing/creating)

@iMarbot
Copy link
Collaborator

iMarbot commented Dec 6, 2024

Anything blocking this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants