Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests and custom datatypes #49

Merged
merged 11 commits into from
Sep 15, 2023
Merged

More tests and custom datatypes #49

merged 11 commits into from
Sep 15, 2023

Conversation

enikao
Copy link
Contributor

@enikao enikao commented Sep 13, 2023

Added Sorted variants of SerializedNode et al. to make comparison easier in tests.

Added more tests:

  • JSON <-> M3
  • JSON <-> SLanguage

Should fix #42, #43

@enikao
Copy link
Contributor Author

enikao commented Sep 13, 2023

@woppa684 Does this address your issues?

@enikao
Copy link
Contributor Author

enikao commented Sep 13, 2023

@ftomassetti Maybe we want to move the Sorted classes to LW-Java?

@woppa684
Copy link

@woppa684 Does this address your issues?

Hard to tell, I don't really know how to review these changes. Any suggestions?

@enikao
Copy link
Contributor Author

enikao commented Sep 13, 2023

@woppa684 Does this address your issues?

Hard to tell, I don't really know how to review these changes. Any suggestions?

Check out the branch locally, or look at the serialized examples (e.g. https://github.com/LIonWeb-org/lioncore-mps/pull/49/files#diff-6941bbdb05685ade5b0849ee331d4c20c14de0e2c0f88bdd2d119a04b8b16029 )

@ftomassetti
Copy link
Contributor

@ftomassetti Maybe we want to move the Sorted classes to LW-Java?

Do you mean SortedSerializedNode and the siblings?
Are they used to facilitate comparisons? Or for something else?

If they are use to facilitate comparisons, for that I have a class to perform comparison (ModelComparator) but I do that at the node level, not at the SerializedNode level.
Why do we need to do that to the SerializedNode level?

@enikao
Copy link
Contributor Author

enikao commented Sep 14, 2023

If they are use to facilitate comparisons, for that I have a class to perform comparison (ModelComparator) but I do that at the node level, not at the SerializedNode level. Why do we need to do that to the SerializedNode level?

Fits better how I handle stuff inside MPS -- I mostly work with SerializedNodes.

@enikao enikao merged commit ad45996 into mps2021.1 Sep 15, 2023
@enikao enikao deleted the niko/custom-datatypes branch September 15, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name is null for PrimitiveTypes
3 participants