-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests and custom datatypes #49
Conversation
@woppa684 Does this address your issues? |
@ftomassetti Maybe we want to move the |
Hard to tell, I don't really know how to review these changes. Any suggestions? |
Check out the branch locally, or look at the serialized examples (e.g. https://github.com/LIonWeb-org/lioncore-mps/pull/49/files#diff-6941bbdb05685ade5b0849ee331d4c20c14de0e2c0f88bdd2d119a04b8b16029 ) |
Do you mean SortedSerializedNode and the siblings? If they are use to facilitate comparisons, for that I have a class to perform comparison (ModelComparator) but I do that at the node level, not at the SerializedNode level. |
…actoryModifier, and ILanguageLookup
…Json2LanguageConverter2
Fits better how I handle stuff inside MPS -- I mostly work with SerializedNodes. |
Added
Sorted
variants ofSerializedNode
et al. to make comparison easier in tests.Added more tests:
Should fix #42, #43