fix: correct the status of a workflow (#21)

Co-authored-by: rick <[email protected]>
LinuxSuRen · Jan 11, 2023 · 8d1e637 · 8d1e637
1 parent 5acf592
commit 8d1e637
Show file tree

Hide file tree

Showing 2 changed files with 158 additions and 9 deletions.
diff --git a/cmd/argoworkflow/main.go b/cmd/argoworkflow/main.go
@@ -96,6 +96,7 @@ func (e *DefaultPluginExecutor) Execute(args executor.ExecuteTemplateArgs, wf *w
 	if wf.Spec.WorkflowTemplateRef != nil {
 		name = wf.Spec.WorkflowTemplateRef.Name
 	}
+	wf.Status.Phase = wfv1.WorkflowPhase(wf.Status.Nodes[wf.Name].Phase)
 	status := wf.Status
 
 	p := args.Template.Plugin.Value
@@ -132,14 +133,6 @@ func (e *DefaultPluginExecutor) Execute(args executor.ExecuteTemplateArgs, wf *w
 		default:
 			repo.Status = strings.ToLower(string(status.Phase))
 		}
-
-		// try to figure out if this is the final step
-		for _, node := range status.Nodes {
-			if node.Type == wfv1.NodeTypePlugin && strings.HasSuffix(node.Name, ".onExit") {
-				repo.Status = "success"
-				break
-			}
-		}
 	}
 	if repo.PrNumber, err = strconv.Atoi(opt.Option.PR); err != nil {
 		err = fmt.Errorf("wrong pull-request number, %v", err)
@@ -169,7 +162,6 @@ func (e *DefaultPluginExecutor) Execute(args executor.ExecuteTemplateArgs, wf *w
 				toRemoves = append(toRemoves, key)
 			}
 		}
-		wf.Status.Phase = wfv1.WorkflowPhase(wf.Status.Nodes[wf.Name].Phase)
 		// remove useless nodes
 		delete(wf.Status.Nodes, wf.Name)
 		for _, key := range toRemoves {