Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to generate json format report #98

Merged
merged 1 commit into from
Jun 19, 2023
Merged

feat: support to generate json format report #98

merged 1 commit into from
Jun 19, 2023

Conversation

setcy
Copy link
Contributor

@setcy setcy commented Jun 19, 2023

close: #78

LinuxSuRen
LinuxSuRen requested changes Jun 19, 2023
View reviewed changes
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. It's great.

I left some comments. Please feel free to check them. And there is one more comment.

It would be more clear if we could put the new format into the command help message. See also

api-testing/cmd/run.go

Line 81 in 6b83420

flags.StringVarP(&opt.report, "report", "", "", "The type of target report. Supported: markdown, md, html, discard, std")

pkg/runner/writer_json.go Outdated Show resolved Hide resolved
pkg/runner/writer_json.go Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

LinuxSuRen
LinuxSuRen approved these changes Jun 19, 2023
View reviewed changes
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Welcome to be the fifth contributor.

By the way, it's not necessary to use force push because the maintainer will squash and merge PR.

@LinuxSuRen LinuxSuRen merged commit ca1a69c into LinuxSuRen:master Jun 19, 2023
@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support to generate JSON format report
2 participants
@setcy @LinuxSuRen