Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot import sub-collection of postman #426

Merged
merged 1 commit into from
May 13, 2024

Conversation

SamYSF
Copy link
Contributor

@SamYSF SamYSF commented May 13, 2024

Fixes #101

What this PR does / why we need it:
1.The original logic cannot convert sub folders beyond one Postman folder.
2.I can only convert the body in JSON format is raw.Therefore,I have modified the structure of the PostmanBody according to the document https://learning.postman.com/collection-format/advanced-concepts/request-definition/. Now, I need to convert it to test suite. Do I need to modify the code structure of test suite Request?

type RequestBody struct {
	Value  string `json:"value" yaml:"value"`
	isJson bool
}

@CLAassistant
Copy link

CLAassistant commented May 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@LinuxSuRen LinuxSuRen added the bug Something isn't working label May 13, 2024
@LinuxSuRen
Copy link
Owner

Do I need to modify the code structure of test suite Request?

I prefer to keep the same for now. Different tools might be different struct. It's impossible to match all of them.

@LinuxSuRen LinuxSuRen added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels May 13, 2024
@LinuxSuRen LinuxSuRen changed the title fix: convert sub postman bug fix: cannot import sub-collection of postman May 13, 2024
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested it. It works well. See my steps:

image
image
image

And happy to have you as the 20th contributor.

@LinuxSuRen LinuxSuRen merged commit 76c60b3 into LinuxSuRen:master May 13, 2024
9 of 11 checks passed
@LinuxSuRen LinuxSuRen added the ospp 开源之夏 https://summer-ospp.ac.cn/ label May 17, 2024
@SamYSF SamYSF deleted the sub-postman-bug branch May 19, 2024 01:08
LinuxSuRen pushed a commit that referenced this pull request Jun 17, 2024
* chore(deps): update postgres docker tag to v16

* Update app version [skip ci]

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-action update-app-version <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ospp 开源之夏 https://summer-ospp.ac.cn/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support converting test cases between atest and postman
3 participants