Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support to generator Python code from a HTTP testCase #371

Closed
wants to merge 7 commits into from
Closed

feat: support to generator Python code from a HTTP testCase #371

wants to merge 7 commits into from

Conversation

zhouzhou1017
Copy link
Contributor

Support to generator Python code from a HTTP testCase (Issue #365)

@LinuxSuRen LinuxSuRen linked an issue Apr 19, 2024 that may be closed by this pull request
Support to generator Python code from a HTTP testCase #365
Closed
@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Apr 19, 2024
@LinuxSuRen LinuxSuRen changed the title update_pygen feat: support to generator Python code from a HTTP testCase Apr 19, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

zhouzhou1017 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

LinuxSuRen
LinuxSuRen requested changes Apr 19, 2024
View reviewed changes
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort. But there are some similar issues to #369. Please check them:

  • License header
  • Unit test failure
  • CLA signing

You can run all the unit tests with command: make test

LinuxSuRen
LinuxSuRen requested changes Apr 23, 2024
View reviewed changes
pkg/generator/python_generator.go Outdated Show resolved Hide resolved
@LinuxSuRen
Copy link
Owner

LinuxSuRen commented Apr 23, 2024 •
edited
Loading

You can resolve the conflicts with following steps:

  • git fetch --all
  • git rebase origin/master
  • fix the conflicts
  • git add .
  • git rebase --continue
  • git push -f

By the way, https://github.com/cli/cli is a very awesome tool. You can try it.

LinuxSuRen
LinuxSuRen reviewed Apr 23, 2024
View reviewed changes
pkg/generator/data/main.python.tpl
@@ -0,0 +1,44 @@
import io
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the license header as well.

@LinuxSuRen LinuxSuRen mentioned this pull request Apr 23, 2024
Closed
5 tasks
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@LinuxSuRen
Copy link
Owner

image
image
image

There are still some issues need to be fixed. An easy way is opening a new PR do to it. And please don't forget set a correct git config --global user.email=xxx and git config --global user.name=xxx

@zhouzhou1017 zhouzhou1017 closed this by deleting the head repository Apr 24, 2024
@LinuxSuRen LinuxSuRen mentioned this pull request Apr 24, 2024
Merged
@LinuxSuRen LinuxSuRen added the ospp 开源之夏 https://summer-ospp.ac.cn/ label May 17, 2024
LinuxSuRen pushed a commit that referenced this pull request Jun 17, 2024
@renovate
chore(deps): update mouday/domain-admin docker tag to v1.5.21 (#371)
91613e9 
* chore(deps): update mouday/domain-admin docker tag to v1.5.21

* Update app version

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: github-action update-app-version <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen requested changes

Assignees
No one assigned
Labels
enhancement New feature or request ospp 开源之夏 https://summer-ospp.ac.cn/
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support to generator Python code from a HTTP testCase
3 participants
@zhouzhou1017 @CLAassistant @LinuxSuRen