Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support running gRPC test cases #160

Merged
merged 20 commits into from
Aug 13, 2023
Merged

feat: support running gRPC test cases #160

merged 20 commits into from
Aug 13, 2023

Conversation

Ink-33
Copy link
Contributor

@Ink-33 Ink-33 commented Aug 5, 2023 •
edited
Loading

Introducing gRPC test case support

In #81, we disscuss about gRPC test cases.

In order to support gRPC, some new fields has been added into testsuite schema. see docs/api-testing-schema.json

Here is a gRPC testsuite sample in sample/grpc-sample.yaml

There is still some work should be done. Please feel free to review.

  • support server reflection
  • add test for gRPC.go

Ink-33
Ink-33 commented Aug 5, 2023
View reviewed changes
pkg/runner/grpc.go Outdated Show resolved Hide resolved
LinuxSuRen
LinuxSuRen requested changes Aug 7, 2023
View reviewed changes
cmd/run.go Outdated Show resolved Hide resolved
pkg/testing/case.go Outdated Show resolved Hide resolved
pkg/runner/grpc.go Outdated Show resolved Hide resolved
pkg/runner/grpc.go Outdated Show resolved Hide resolved
pkg/runner/grpc.go Outdated Show resolved Hide resolved
@LinuxSuRen LinuxSuRen added enhancement New feature or request glcc Special for https://www.gitlink.org.cn/glcc backend labels Aug 7, 2023
@Ink-33
refactor: move verify out of runtestcase
9d8b4b9 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: use factory to get runner
a01f414 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
feat: new package pkg/compare
c418022 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: use body field instead of payload
0edbcf5 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: new default testcase implement
55faec8 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: reduce code complexity
11d7ca4 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: remove package errors
d9002bd 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: method of TestCaseRunner will not return itself
a9935ac 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
test: fix unit test
6ee92f7 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
fix: error should be return in verify
1323c92 
Signed-off-by: Ink33 <[email protected]>
@Ink-33
style: revert style change to yaml
2cef5bb 
revert 78680f

Signed-off-by: Ink33 <[email protected]>
@Ink-33
refactor: reduce code complexity
73c1382 
Signed-off-by: Ink33 <[email protected]>
LinuxSuRen
LinuxSuRen requested changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part. But you still need to handle the license header issue.

pkg/runner/runner_factory.go Show resolved Hide resolved
pkg/testing/case.go Outdated Show resolved Hide resolved
@Ink-33 Ink-33 marked this pull request as ready for review August 13, 2023 12:57
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

LinuxSuRen
LinuxSuRen approved these changes Aug 13, 2023
View reviewed changes
Copy link
Owner

@LinuxSuRen LinuxSuRen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@LinuxSuRen LinuxSuRen merged commit 18bd198 into LinuxSuRen:master Aug 13, 2023
7 checks passed
@Ink-33 Ink-33 deleted the grpc_test branch August 13, 2023 13:20
@Ink-33 Ink-33 mentioned this pull request Sep 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxSuRen LinuxSuRen LinuxSuRen approved these changes

Assignees
No one assigned
Labels
backend enhancement New feature or request glcc Special for https://www.gitlink.org.cn/glcc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ink-33 @LinuxSuRen