Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dark theme is hard to view #181

Open
LinuxSuRen opened this issue Aug 23, 2023 · 15 comments
Open

The dark theme is hard to view #181

LinuxSuRen opened this issue Aug 23, 2023 · 15 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@LinuxSuRen
Copy link
Owner

This project is using element-plus.

image

@LinuxSuRen LinuxSuRen added the good first issue Good for newcomers label Aug 23, 2023
@Axxi3
Copy link

Axxi3 commented Aug 23, 2023

is anyone working in this issue, or can i work in it???

@LinuxSuRen
Copy link
Owner Author

LinuxSuRen commented Aug 23, 2023

hi @Axxi3 , so happy to have you working on this issue.

You can start the backend in the root directory of this repo: go run . server

then, start the front-end: cd console/atest-ui && npm install && npm run dev

@LinuxSuRen
Copy link
Owner Author

Hi @Axxi3 how is going? Do you need any kinds of help?

@LinuxSuRen
Copy link
Owner Author

hi @Axxi3 I'm going to cancel the asign status due to no response from you in a long time.

@kuv2707
Copy link
Contributor

kuv2707 commented Oct 14, 2023

Hi @LinuxSuRen
I would like to take charge of this issue

@LinuxSuRen
Copy link
Owner Author

That's great. I'm not familiar with the front-end tech. So glad that you could improve it.

By the way, do I need to assign this issue to you?

@kuv2707
Copy link
Contributor

kuv2707 commented Oct 14, 2023

It would be nice if you did

@LinuxSuRen
Copy link
Owner Author

hi @kuv2707, I'm thinking that we could just add a switch button to switch the theme between light and dark for now. Then improve the view later.

@kuv2707
Copy link
Contributor

kuv2707 commented Oct 21, 2023

We can surely do that.
Right now its using media queries.
I had faced problems trying to work with element-plus, but adding a button won't be difficult.

@LinuxSuRen
Copy link
Owner Author

I totally understand that we could do it step-by-step.

@suoaiyisheng
Copy link

Is this issue over? I'd like to try that

@LinuxSuRen
Copy link
Owner Author

LinuxSuRen commented Apr 30, 2024

hi @suoaiyisheng , thanks for your attention. Please go ahead. I don't know why the switch button of dark mode is missing. Please help on it.

@suoaiyisheng
Copy link

suoaiyisheng commented May 1, 2024

@LinuxSuRen hi👋!你看看这个效果可以吗?
黑暗模式效果

@LinuxSuRen
Copy link
Owner Author

@suoaiyisheng 看起来效果还不错,可以把 PR 提上来看看

@LinuxSuRen
Copy link
Owner Author

hi @suoaiyisheng ,方便的时候,可以提个 PR 哈

LinuxSuRen pushed a commit that referenced this issue Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants