Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 223 - enable e2e db2 tests during Integration build #640

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Issue 223 - enable e2e db2 tests during Integration build #640

merged 4 commits into from
Jan 28, 2020

Conversation

lmsurpre
Copy link
Member

@lmsurpre lmsurpre commented Jan 28, 2020 •
edited
Loading

Refactored the old/stale dockerized integration tests to use db2, including:

  • simplified docker-compose env to just two services: fhir and db2
    • the fhir image is built from Dockerfile-ol which is OpenLiberty on Redhat UBI
  • new files under fhir-install, including
    • docker/copy-dependencies-db2.sh
    • docker/deploySchemaAndTenant.sh
    • docker/db2.properties
    • src/test/resources/fhir-server-config-db2.json

Note: I found #639 in the process. I've worked around that issue by updating the tests to avoid testing the "fallback to default tenant" behavior.

@prb112
Copy link
Contributor

prb112 commented Jan 28, 2020 •
edited
Loading 

 + java -jar volumes/schema/fhir-persistence-schema-4.0.1-SNAPSHOT-cli.jar --prop-file db2.properties --schema-name FHIRDATA --create-schemas
Error: Unable to access jarfile volumes/schema/fhir-persistence-schema-4.0.1-SNAPSHOT-cli.jar

@lmsurpre
add detail to FHIRValidator javadoc
920707b 
based on a user question about what is the behavior for
resource-asserted profiles that are unknown to the server

Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
refactored docker integration tests to use db2
1318681 
Signed-off-by: Lee Surprenant <[email protected]>
@lmsurpre
update failing integration tests to avoid fallback to default dsid
83a184d 
Signed-off-by: Lee Surprenant <[email protected]>
@prb112 prb112 added automation automation enhancement New feature or request labels Jan 28, 2020
@prb112 prb112 added this to the Sprint 8 milestone Jan 28, 2020
prb112
prb112 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112
Copy link
Contributor

prb112 commented Jan 28, 2020

interesting... failure above?

@lmsurpre lmsurpre merged commit 4bf296b into LinuxForHealth:master Jan 28, 2020
@lmsurpre lmsurpre removed this from the Sprint 8 milestone Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prb112 prb112 prb112 approved these changes

@JohnTimm JohnTimm Awaiting requested review from JohnTimm

@albertwang-ibm albertwang-ibm Awaiting requested review from albertwang-ibm

Assignees

@lmsurpre lmsurpre

Labels
automation automation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmsurpre @prb112