issue #4101 - call beforeX interceptor methods prior to checking if update is skippable #4105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmsurpre
force-pushed
the
issue-4101-b
branch
from
10c60e4 to
310c01e
Compare
…pdate is skippable Previously, a skippable update (one that would not affect the contents of the resource being updated) would result in a success without invoking beforeUpdate or beforePatch interceptor methods. For users of fhir-smart, this behavior is confusing because the user may not have write access to this resource type, but the server is "allowing" the write anyway (even though its being optimized away). Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre
force-pushed
the
issue-4101-b
branch
from
0f0cfec to
0744f23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a skippable update (one that would not affect the contents of the resource being updated) would result in a success without invoking beforeUpdate or beforePatch interceptor methods.
For users of fhir-smart, this behavior is confusing because the user may not have write access to this resource type, but the server is "allowing" the write anyway (even though its really being optimized away).
Signed-off-by: Lee Surprenant [email protected]