issue #3390 - align ResourceTypeName with the R4 ResourceType enum #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could have sworn I did this before, but its definitely out-of-sync in main. This changeset re-aligns the two so that: 1. we don't end up trying to us a resource type that doesn't exit in R4 2. we don't miss any resource types that existed in R4 but are being removed for R4B Signed-off-by: Lee Surprenant <[email protected]>
We found that, due to the issue with ResourceTypeName, a system export was invoking FHIRPersistenceJDBCImpl.changes() with a list of type names that includes invalid values. Previously, that led to an invalid SQL statement. Now we will filter out the invalid names (and throw if some were passed but none were found). Signed-off-by: Lee Surprenant <[email protected]>
punktilious
reviewed
Apr 5, 2022
...rsistence-jdbc/src/main/java/com/ibm/fhir/persistence/jdbc/impl/FHIRPersistenceJDBCImpl.java
Outdated
Show resolved
Hide resolved
…dbc/impl/FHIRPersistenceJDBCImpl.java Signed-off-by: Lee Surprenant <[email protected]> Co-authored-by: Robin Arnold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could have sworn I did this before, but its definitely out-of-sync in
main. This changeset re-aligns the two so that:
removed for R4B
Signed-off-by: Lee Surprenant [email protected]