#3195 - Bubble up exception message from CQL engine #3210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CQL operations were wrapping the exception from the CQL engine in a FHIROperationException as assuming that the nested exception would automatically be included in the issues list which isn't the case at all. I added logic to manually add the details from the CQLException to the issues list so that it shows up in the OperationOutcome. Signed-off-by: Corey Sanders <[email protected]>
prb112
reviewed
Jan 19, 2022
fhir-server-test/src/test/java/com/ibm/fhir/server/test/cpg/ServerCqlOperationTest.java
Show resolved
Hide resolved
prb112
reviewed
Jan 19, 2022
fhir-server-test/src/test/java/com/ibm/fhir/server/test/cpg/ServerCqlOperationTest.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jan 19, 2022
...on/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/LibraryEvaluateOperation.java
Show resolved
Hide resolved
prb112
reviewed
Jan 19, 2022
...ration/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/AbstractCqlOperation.java
Show resolved
Hide resolved
prb112
approved these changes
Jan 19, 2022
Signed-off-by: Corey Sanders <[email protected]>
lmsurpre
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CQL operations were wrapping the exception from the CQL engine in a
FHIROperationException and assuming that the nested exception would
automatically be included in the issues list which isn't the case at
all. I added logic to manually add the details from the CQLException to
the issues list so that it shows up in the OperationOutcome.
Signed-off-by: Corey Sanders [email protected]