Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #2 - condense projects and update FHIRServerUsersGuide.md #320

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

lmsurpre
Copy link
Member

@lmsurpre lmsurpre commented Oct 28, 2019

  1. moved java classes from fhir-client-sample and
    fhir-connectathon-clients into fhir-client/src/test/java and deleted
    these projects

  2. organized FHIRConfiguration properties and removed stale properties:

  • jsonParserLenient
  • jsonParserValidating
  • encryption
  1. removed stale properties (whclsfRouter and the above) from all
    fhir-server-config.json examples

  2. updated FHIRServerUsersGuide

  • removed stale properties from all config snippets and the properties reference tables in section 5
  • cleared "Recent updates" section and removed link to CHANGELOG
  • updated CapabilityStatement snippet
  • updated some references from WebSphere Liberty to OpenLiberty
  • removed references to liquibase; now we have custom code for database schema migration. but documentation in this area needs significant work, starting with Document the schema migration process on the project wiki #270

Signed-off-by: Lee Surprenant [email protected]

@lmsurpre lmsurpre requested a review from prb112 October 28, 2019 11:37
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - a scan through it looks good to me

1. moved java classes from `fhir-client-sample` and
`fhir-connectathon-clients` into `fhir-client/src/test/java` and deleted
these projects

2. organized FHIRConfiguration properties and removed stale properties:
  * jsonParserLenient
  * jsonParserValidating
  * encryption

3. removed stale properties (whclsfRouter and the above) from all
fhir-server-config.json examples

4. updated FHIRServerUsersGuide
  * removed stale properties from all config snippets and the properties
reference tables in section 5
  * cleared "Recent updates" section and removed link to CHANGELOG
  * updated CapabilityStatement snippet
  * updated some references from WebSphere Liberty to OpenLiberty
  * removed references to liquibase; now we have custom code for
database schema migration.  but documentation in this area needs
significant work, starting with #270


Signed-off-by: Lee Surprenant <[email protected]>
@prb112 prb112 merged commit abb66b9 into master Oct 28, 2019
@prb112 prb112 deleted the issue-2 branch October 28, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants