Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2751 2756 prevent concurrent schema updates and support whole_system_schema healthcheck #2880

Merged
merged 9 commits into from
Oct 21, 2021
Merged

Issue 2751 2756 prevent concurrent schema updates and support whole_system_schema healthcheck #2880

merged 9 commits into from
Oct 21, 2021

Conversation

punktilious
Copy link
Collaborator

@punktilious punktilious requested a review from lmsurpre October 21, 2021 11:34
lmsurpre
lmsurpre reviewed Oct 21, 2021
View reviewed changes
...tabase-utils/src/main/java/com/ibm/fhir/database/utils/version/CreateWholeSchemaVersion.java
Comment on lines +77 to +78
// apply this data model to the target if necessary - note - this table
// is not managed in the VERSION_HISTORY table
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to manage this one in VERSION_HISTORY? hopefully simple-enough that we shouldn't ever need to change it, but I thought we'd still have it there

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it has to be available before we process anything with version history. It's describing the schema version itself, so I didn't want to create some sort of circular dependency.

lmsurpre
lmsurpre reviewed Oct 21, 2021
View reviewed changes
fhir-persistence-schema/src/test/java/com/ibm/fhir/schema/derby/DerbySchemaVersionsTest.java
Comment on lines +59 to +61
// Make sure we can correctly determine the latest schema version value
svm.updateSchemaVersion();
assertEquals(svm.getVersionForSchema(), FhirSchemaVersion.V0020.vid());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this break when we go to V0021? I guess we just need to remember to come in here and update this line after each schema change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will break (intentionally)

@lmsurpre lmsurpre self-requested a review October 21, 2021 19:11
lmsurpre
lmsurpre approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@lmsurpre lmsurpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@punktilious punktilious merged commit 339a3bd into main Oct 21, 2021
@punktilious punktilious deleted the issue-2751 branch October 21, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmsurpre lmsurpre lmsurpre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punktilious @lmsurpre