DO NOT SQUASH: Implement initial support for CQL-related operations #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: John T.E. Timm <[email protected]>
Signed-off-by: John T.E. Timm <[email protected]>
Issue #2480 - pre-compute type map for resolveType method
Signed-off-by: John T.E. Timm <[email protected]>
Issue #2480 - updated typeMap creation and usage
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Includes bug fixes for bugs found in CPG operations during testing. Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
* Had to overhaul the FhirBundleCursor to deal with empty bundles returned due to the total=none optimization * Had to rework the LibraryEvaluate expression parameter handling * Had to update the FhirTypeConverter toCqlDatetime logic to handle temporal values without a zone offset. * Added some logging to help figure out what is going on in the server retrieve provider. Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
…ependencies Signed-off-by: Corey Sanders <[email protected]>
This implementation is based on the cqf-ruler implementation which seems like it needs to be refined in future work. For now, though, we keep parity with the reference. Signed-off-by: Corey Sanders <[email protected]>
prb112
reviewed
Jul 12, 2021
...server/src/main/java/com/ibm/fhir/cql/engine/server/retrieve/ServerFhirRetrieveProvider.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 12, 2021
...server/src/main/java/com/ibm/fhir/cql/engine/server/retrieve/ServerFhirRetrieveProvider.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 12, 2021
.../src/main/java/com/ibm/fhir/cql/engine/server/terminology/ServerFhirTerminologyProvider.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/CqlLibraryComparator.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/CqlOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/CqlOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
...on/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/LibraryEvaluateOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/ParameterConverter.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/ParameterConverter.java
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cpg/src/main/java/com/ibm/fhir/operation/cpg/ParameterConverter.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
prb112
reviewed
Jul 13, 2021
...peration-cqf/src/main/java/com/ibm/fhir/operation/cqf/AbstractDataRequirementsOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
operation/fhir-operation-cqf/src/main/java/com/ibm/fhir/operation/cqf/CareGapsOperation.java
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
.../fhir-operation-cqf/src/main/java/com/ibm/fhir/operation/cqf/MeasureSubmitDataOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
.../fhir-operation-cqf/src/main/java/com/ibm/fhir/operation/cqf/MeasureSubmitDataOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
.../fhir-operation-cqf/src/main/java/com/ibm/fhir/operation/cqf/MeasureSubmitDataOperation.java
Outdated
Show resolved
Hide resolved
prb112
reviewed
Jul 13, 2021
...-operation-cqf/src/test/java/com/ibm/fhir/operation/cqf/MeasureCollectDataOperationTest.java
Show resolved
Hide resolved
This was referenced Jul 15, 2021
Signed-off-by: Corey Sanders <[email protected]>
Signed-off-by: Corey Sanders <[email protected]>
prb112
changed the title
|
I brought your PR up to date and updated the automation and readme. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working for the last two cohorting sprints on implementing an IBM FHIR native backend for the open source CQL engine and building out operations that support the most directly useful parts of the Clinical Practice Guidelines and Quality Measures IGs. #2480
This is an initial step. It is not a complete implementation of either IG and the quality measure and reporting space is being actively developed and changed right now and will need further development to keep up with standards. For example, both the May2021 ballot of the CQF measures IG and Davinci change some of the operations that were implemented here.
My intention is to get this foundational work integrated with the IBM FHIR server so that the Alvearie/quality-measure-and-cohort-engine project can start building on top of it. This will also provide a simple onramp for IBM FHIR server users that are interested in cohorting or clinical quality measure evaluation and want to get started quickly with the fewest number of dependencies. Clinical quality reporting operations are implemented in such a way that clients can either use the CQL engine remotely as expected in the R1 release of the cohort engine or evaluation could be done directly in IBM FHIR via the Library/$evaluate and Measure/$evaluate-measure operations, so as to avoid additional data hops necessary for evaluation in the client/server mode of operation.
New projects added in this PR:
fhir-cql -- Foundation classes for implementing the CQL Engine backend in IBM FHIR
fhir-cql-rest -- REST Client-based implementation of CQL Engine backend
fhir-cql-server -- Internal API-based implementation of CQL Engine backend
fhir-quality-measure -- FHIR Quality Measure evaluation logic
operation/fhir-operation-cpg -- Optional module that implements CQL operations
operation/fhir-operation-cqf -- Optional module that implements CQF operations
Operations provided by this work include:
#CPG
#CQF
The CQF IG describes dataflows that also involve the
ActivityDefinition/$applyandPlanDefinition/$applyoperations. Some prior work was done by @JohnTimm in the fhir-operation-apply module, but without support for CQL. This work has not been integrated with that work yet.