issue #1351 - Check SearchParameter search restrictions #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prb112
reviewed
Oct 13, 2020
tbieste
force-pushed
the
tbieste-issue-1351
branch
from
c4d0802 to
108f210
Compare
Signed-off-by: Troy Biesterfeld <[email protected]>
tbieste
force-pushed
the
tbieste-issue-1351
branch
from
108f210 to
b11e8a4
Compare
Signed-off-by: Troy Biesterfeld <[email protected]>
tbieste
force-pushed
the
tbieste-issue-1351
branch
from
b11e8a4 to
8398b13
Compare
|
@lmsurpre An example config with the new fields is fhir-search/src/test/resources/config/tenant7/fhir-server-config.json |
lmsurpre
reviewed
Oct 16, 2020
fhir-config/src/main/java/com/ibm/fhir/config/FHIRConfiguration.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/main/java/com/ibm/fhir/search/util/SearchUtil.java
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/test/resources/config/tenant1/fhir-server-config.json
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/test/resources/config/tenant4/fhir-server-config.json
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/test/resources/config/tenant5/fhir-server-config.json
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-search/src/test/resources/config/tenant7/fhir-server-config.json
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-server/liberty-config-tenants/config/tenant1/fhir-server-config.json
Outdated
Show resolved
Hide resolved
lmsurpre
reviewed
Oct 16, 2020
fhir-server/liberty-config-tenants/config/tenant1/fhir-server-config.json
Show resolved
Hide resolved
based on team discussion Signed-off-by: Lee Surprenant <[email protected]>
lmsurpre
reviewed
Oct 16, 2020
|
|
||
| if (supportOmittedRsrcTypes) { | ||
| // All other resource types include all search parameters | ||
| result.put(SearchConstants.WILDCARD, Collections.singletonList(SearchConstants.WILDCARD)); |
There was a problem hiding this comment.
would it be helpful (perf-wise) to have this singletonList in a constant?
|
we still need to update the docs to reflect the new config changes but I will do that as part of #1449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update enables checking of SearchParameter search restrictions and updates the FHIR server config file with a resources group that will provide configuration for additional search restrictions. Checking of required search parameters, includes, and revincludes will be in an upcoming commit.
Signed-off-by: Troy Biesterfeld [email protected]