Merge pull request nextcloud#33293 from nextcloud/last-login-minute

only update last login timestamp with minute percision
LinneyS · Jul 21, 2022 · afedfad · afedfad
2 parents 33a9c7f + 9e34a21
commit afedfad
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/lib/private/User/User.php b/lib/private/User/User.php
@@ -244,10 +244,15 @@ public function getLastLogin() {
 	 * updates the timestamp of the most recent login of this user
 	 */
 	public function updateLastLoginTimestamp() {
-		$firstTimeLogin = ($this->getLastLogin() === 0);
-		$this->lastLogin = time();
-		$this->config->setUserValue(
-			$this->uid, 'login', 'lastLogin', (string)$this->lastLogin);
+		$previousLogin = $this->getLastLogin();
+		$now = time();
+		$firstTimeLogin = $previousLogin === 0;
+
+		if ($now - $previousLogin > 60) {
+			$this->lastLogin = time();
+			$this->config->setUserValue(
+				$this->uid, 'login', 'lastLogin', (string)$this->lastLogin);
+		}
 
 		return $firstTimeLogin;
 	}