Bubbles phantomJS errors to Venus. #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent errors with scripts loading, require dependencies, or failing initial page load code from flying the under the radar when using Venus. Instead of passing the test with `0 tests passed for that file`, it now increments the error count and prints the stacktrace to the console.
|
Additionally, fixed a few typos and remove some unused variables. |
|
@rbakr Fixed the issues you've raised for my PR. Good catch with the bind. 👍 |
rbakr
added a commit
that referenced
this pull request
Oct 21, 2015
Bubbles phantomJS errors to Venus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Broken Test Files (IE: Require dependency, error in initial script load, anything that breaks the page in Phantom before tests actually start running) are skipped, with Venus accepting
0 passed, 0 failed.This fix increments the error count if that should happen, and prints the stacktrace to the console.