Add support for JDK8 output when using CMS #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full JDK8 support includes more work, since PermGen is no longer present in JDK8, and there is Metaspace, which should probably also have some metrics. |
This seems relevant also for pre JDK8.
Define variable for gc_timestamp regular expression, the expression is without timezone, should perhaps be with timezone. Add support for having gc_timestamp_re on concurrent mode failure line. But the whole logic there is a bit strange, because the time recorded for gen1t in that case is not printed at all.
| # /\[GC.*\[(DefNew|(AS)?ParNew): [0-9]+K->[0-9]+K\([0-9]+K\),.*secs\] [0-9]+K->[0-9]+K\([0-9]+K\),.*secs\]/ { | ||
| $0 ~ "\\[GC " timestamp_re "\\[" fw_yng_gen_re ": " heap_report_re "\\] " heap_report_re "\\]" { | ||
| $0 ~ "\\[GC (\\(Allocation Failure\\) )?" timestamp_re "\\[" fw_yng_gen_re ": " heap_report_re "\\] " heap_report_re "\\]" { |
There was a problem hiding this comment.
Multiple types of causes, in addition to Allocation Failure, can lead to ParNew GC, it would be nice to have a wild card with pattern something like GC (xxxx)
|
Awesome, thanks Alf for the clarifications. This should be good! |
richardhsu
added a commit
that referenced
this pull request
Apr 8, 2015
Add support for JDK8 output when using CMS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My changes seems to be working, but I have not tested with other garbage collectors than CMS.
I might have time to test with other next week.
This is a suggested fix for issue #296.
Could you please review, and let me know if it looks good ?