-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial step to switch to grunt build. #62
Conversation
Grunting is awesome! |
@@ -15,19 +15,13 @@ | |||
<script src="../spec/renderTestSpec.js" type="text/javascript" charset="utf-8"></script> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does grunt-contrib-jasmine create a spec runner? Is this file still used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grunt-contrib-jasmine creates a spec runner in the root directory of the project. It is deleted though after grunt jasmine is ran because of "keepRunner:false" option.
Eventually this files will be replaces by grunt jasmine task
Please update the travis files. The grunt jasmine runner assumes Node 0.8 +. Let's test 0.8 and 0.10 |
Looks good, but I defer to Jimmy on the heavy duty grunt stuff. |
@@ -38,7 +38,7 @@ | |||
} | |||
], | |||
"scripts": { | |||
"test" : "node test/jasmine-test/server/specRunner.js", | |||
"test": "node test/jasmine-test/server/specRunner.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is what travis will run npm test
should this be grunt test
instead
can we also please add .npmignore we should ignore everything this is not required to run (so tests can be npm ignored). you can check it by
|
"cover" : "0.2.x", | ||
"dustjs-linkedin": "2.2.x" | ||
"jasmine-node": "~1.13.0", | ||
"cover": "~0.2.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't need this any more?
Added .npmignore and tested to make sure only necessary things are copied with .npmignore |
Looks good to go. Can we squash these commits down to 1. |
Initial step to switch to grunt build process.
Adding grunt support to uglify dust-helpers.js and run jasmine unit tests in phantom