Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stackplot yticks #595

Merged
merged 6 commits into from
Jul 3, 2024
Merged

Stackplot yticks #595

merged 6 commits into from
Jul 3, 2024

Conversation

CommonClimate
Copy link
Collaborator

and docstring bug fix. This does not have to be perfect, just good enough

Copy link
Contributor

@jordanplanders jordanplanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to separate customization for y axis limits and y axis ticks. One option would be to specify the bounding stye as "tight" (mean +/-n*std) or "auto" (matplotlib fall back). This would put the set_ylim code back where it was previously.

and docstring and pytests
@CommonClimate
Copy link
Collaborator Author

Good idea. I added the following options (and docstring):

yticks_minor : bool
            Whether the y axes should contain minor ticks (use sparingly!). Default: False
        
        xticks_minor : bool 
            Whether the x axis should contain minor ticks. Default: False
        
        ylims : str {'spacious', 'auto'}
            Method for determining the limits of the y axes. 
            Default is 'spacious', which is mean +/- 4 x std
            'auto' activates the Matplotlib default

and the pytests to go with it.

@CommonClimate CommonClimate requested a review from alexkjames July 3, 2024 17:19
@alexkjames alexkjames merged commit 807652d into master Jul 3, 2024
1 check passed
@alexkjames alexkjames deleted the stackplot_yticks branch July 3, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants