Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uar1 surrogates #537

Merged
merged 10 commits into from
Apr 22, 2024
Merged

uar1 surrogates #537

merged 10 commits into from
Apr 22, 2024

Conversation

CommonClimate
Copy link
Collaborator

Implemented the discussed changes, including:

  • complete redesign of SurrogateSeries, with 2 methods from_series() and from_param(), with extensive tests
  • fixed settings for Series.correlation(); introduced new argument number, but allowed back-compatibility with settings['nsim']
  • enabled PSD, Coherence and Scalogram objects with new surrogate series syntax.

Causality is a bigger endeavor, which I leave for a future PR

@CommonClimate CommonClimate requested a review from khider April 19, 2024 23:46
@CommonClimate CommonClimate mentioned this pull request Apr 19, 2024
Copy link
Member

@khider khider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for now, but these changes may be subject to change when we work on the tutorials.

@khider khider merged commit 05d0949 into master Apr 22, 2024
1 check passed
@CommonClimate CommonClimate deleted the uar1_surrogates branch May 24, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants