Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

uar1 surrogates #534

Merged
merged 25 commits into from
Apr 11, 2024
Merged

uar1 surrogates #534

merged 25 commits into from
Apr 11, 2024

Conversation

lionelvoirol
Copy link
Collaborator

  • renamed estimation and generating function for MLE estimation and generation of unevenly AR1 model as uar1_fit and uar1_sim.
  • allow for uar1_fitto take a time index vector.
  • define random time index generation function outside of uar1_fit and uar1_sim.
  • allow to generate surrogate specifying method uar1_sim .
  • introduce argument time_pattern in surrogate method to allow for different time index generation.
  • allow spectral analysis and scalograms with uar1.
  • develop various test for new methods.

CommonClimate and others added 25 commits March 27, 2024 10:20
@CommonClimate
renamed Lionel's functions to uar1
ac469a1 
CI tests pass
@CommonClimate
stub out uar1 surrogates
4b1a19b 
TODO list in comments
@lionelvoirol
add option for the distribution of the delta_t in fct time_increments
967b3c9
@lionelvoirol
added delta_t_dist 'empirical' in fct time_increments, added support …
96de6ff 
…for uar1 in surrogates, try to develop test
@lionelvoirol
minor
d3feebe
@lionelvoirol
minor
f047dcd
@lionelvoirol
trying to understand how to load current pkg with new fcts
c568a45
@lionelvoirol
more weird stuff
177328f
@lionelvoirol
better exception handling
a355ed2
@CommonClimate
stub out surrogate time_pattern
14e2d7a
@CommonClimate
renamed time_increments to random_time_increments
c1f65ab
@lionelvoirol
minor
756fb97
@lionelvoirol
Merge branch 'uar1_surrogates' of github.com:LinkedEarth/Pyleoclim_ut…
f76489e 
…il into uar1_surrogates
@lionelvoirol
modified uar1_sim to accept time index as an argument, change fct ran…
c2329cf 
…dom_time_increment to random_time_index,modified tests
@lionelvoirol
develop time_pattern match in surrogates
cdecd09
@lionelvoirol
develop time_pattern even in surrogates
ae2049b
@lionelvoirol
implement time_pattern uneven in surrogate when method is uar1
56372aa
@lionelvoirol
better test for surrogate with uar1 uneven sampling
a6ee33d
@lionelvoirol
minor
5394ae7
@CommonClimate
Redesigned uar1_sim
d5244f9 
made it univariate, since trying to return a matrix was surprisingly buggy.
@CommonClimate
Most tests moved to core.Series
1343897 
and fixed
@CommonClimate
minor changes to Series.correlation()
5b7362e 
(cf Pyleo dvlpt call on 04/05/2024)
@CommonClimate
minor reformatting
1857e16
@CommonClimate
enabled spectral analysis tests with uar1
ec52d0d
@CommonClimate
enabled scalograms
494d6c7
CommonClimate
CommonClimate approved these changes Apr 11, 2024
View reviewed changes
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

@CommonClimate CommonClimate merged commit ce46bd4 into master Apr 11, 2024
1 check passed
@CommonClimate CommonClimate deleted the uar1_surrogates branch April 11, 2024 05:33
@CommonClimate CommonClimate mentioned this pull request Apr 11, 2024
Closed
@CommonClimate CommonClimate mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommonClimate CommonClimate CommonClimate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionelvoirol @CommonClimate