Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added auto_time_params to GeoSeries to make it consistent with Series #523

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Added auto_time_params to GeoSeries to make it consistent with Series #523

merged 1 commit into from
Feb 16, 2024

Conversation

khider
Copy link
Member

@khider khider commented Feb 16, 2024

As the title indicates. Also ticked the Pyleoclim version up.

@khider khider requested a review from CommonClimate February 16, 2024 01:18
CommonClimate
CommonClimate reviewed Feb 16, 2024
View reviewed changes
Copy link
Collaborator

@CommonClimate CommonClimate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re: GeoSeries, why do we need this parameter here, given that it's a child of Series, which already has it?

@khider
Copy link
Member Author

khider commented Feb 16, 2024

You still need it to declare the GeoSeries. Otherwise you would not need value and time by this same reasoning. Inheritance is for methods.

@CommonClimate CommonClimate merged commit fe46e0b into master Feb 16, 2024
1 check passed
@CommonClimate CommonClimate deleted the geoseries branch February 16, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CommonClimate CommonClimate CommonClimate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khider @CommonClimate