add auto_time_params arg to series init #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
let's see how many things that breaks
|
Thanks for doing this @alexkjames ! I'll review this week. |
|
I seem to remember @khider wanting |
|
I think we should have it True for a while so it mimics the behavior of the current version and have a warning that it will be set to False in subsequent releases. |
|
That sounds good. @alexkjames can you do that and update the PR? |
slight tweaks to language for docstring and user warning
CommonClimate
approved these changes
Nov 15, 2023
|
closes #469 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address Issue #469
I've just added an
auto_time_paramsargument to Series, and nested the time name/unit logic within anifstatement that relies on the value ofauto_time_params.This is the simplest fix to issue #469. We discussed having a way to switch a series in between having auto and not auto time params, but I'm not sure this is necessary. If it is I'm happy to create a function to do so, though I might suggest waiting until such a thing is requested/it becomes clear that we need it since creating Series objects is already pretty straightforward.
Was there anything else we wanted to do here?