Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeplot pc units #449

Merged
merged 8 commits into from
Jun 30, 2023
Merged

Modeplot pc units #449

merged 8 commits into from
Jun 30, 2023

Conversation

CommonClimate
Copy link
Collaborator

This PR initially aimed to address #447, but ended up tackling a few minor things along the way, including:

  • harmonizing how MultivarDecomp and SSARes objects call the original series
  • inference of period_unit from time_unit in PSD (used to add an "s" at the end, which made sense for years but nothing else).
    • handling of offending time_name/unit combos like 'C.E' (not a unit) --> years CE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant