dev-docker: fix to work with current Dockerfile #513
Conversation
terceiro
requested review from
chaws,
mwasilew and
stevanradakovic
as code owners
| @@ -7,7 +7,10 @@ | |||
|
|
|||
|
|
|||
| def javascript_tests(): | |||
| if os.path.exists(karma): | |||
| if not shutil.which('nodejs'): | |||
There was a problem hiding this comment.
Is there a scenario where "node_modules/.bin/karma" exists where "nodejs" doesn't? When installing npm, Debian seems to be installing nodejs too.
There was a problem hiding this comment.
the scenario that I hit, which is I had this stuff installed in my host machine, but not in the container created by dev-docker
(I tried to add nodejs etc to it, but chromium crashes weirdly inside docker and I didn't want to investigate that at the moment)
There was a problem hiding this comment.
(just saw you other comment)
|
Maybe we should have javascript tests within the dev-docker? Just a suggestion...I added npm and chromium to apt in dev dockerfile then added no-sandbox to karma config and it worked fine, it just added a much greater amount of time and space |
|
@chaws so that's the trick, --no-sandbox. I will amend |
No description provided.