Add atan support for missings (JuliaLang#43523)

Allowing atan to deal with two missing arguments
LilithHafner · Mar 8, 2022 · 9238fdd · 9238fdd
1 parent 76c51b6
commit 9238fdd
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/base/math.jl b/base/math.jl
@@ -1318,6 +1318,9 @@ for f in (:sin, :cos, :tan, :asin, :atan, :acos,
     end
     @eval $(f)(::Missing) = missing
 end
+atan(::Missing, ::Missing) = missing
+atan(::Number, ::Missing) = missing
+atan(::Missing, ::Number) = missing
 
 exp2(x::AbstractFloat) = 2^x
 exp10(x::AbstractFloat) = 10^x

diff --git a/test/missing.jl b/test/missing.jl
@@ -109,6 +109,19 @@ end
     end
 end
 
+@testset "two-argument functions" begin
+    two_argument_functions = [atan]
+
+    # All two-argument functions return missing when operating on two missing's
+    # All two-argument functions return missing when operating on a scalar and an missing
+    # All two-argument functions return missing when operating on an missing and a scalar
+    for f in two_argument_functions
+        @test ismissing(f(missing, missing))
+        @test ismissing(f(1, missing))
+        @test ismissing(f(missing, 1))
+    end
+end
+
 @testset "bit operators" begin
     bit_operators = [&, |, ⊻]