Only process and upload code coverage results in two configurations. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To wait for both uploads to process before reporting statuses to avoid transient x's
|
We upload somewhere between 10 and 100 builds... |
|
I sure do wish there was an easier way to find out how many |
|
15 |
|
Which is the number of matrix entries; looks like the if is broken |
|
Looks great! Can confirm 2 uploads, and when watching the checks roll in I never saw the codecov checks until both min/x64/ubuntu and 1/x86/ubuntu had finished. The drop in coverage is likely due to changes in how lines are counted as "lines of code" or not in various versions of Julia. The diff is 3 lines that were previously "covered" are now untracked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should cover everything in one of these two cases.