Merge pull request #2 from Lightricks/PHOTO-1087_fix_buildtime_warnings

[PHOTO-1087] fix buildtime warnings (Xcode 14)
Lightricks · Nov 16, 2022 · ea29235 · ea29235
2 parents 81efd63 + d53831d
commit ea29235
Show file tree

Hide file tree

Showing 11 changed files with 172 additions and 171 deletions.
diff --git a/Rx.xcodeproj/project.pbxproj b/Rx.xcodeproj/project.pbxproj
diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/AllTests-iOS.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/AllTests-iOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/AllTests-macOS.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/AllTests-macOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/AllTests-tvOS.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/AllTests-tvOS.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/RxBlocking.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/RxBlocking.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/RxCocoa.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/RxCocoa.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/RxRelay.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/RxRelay.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/RxSwift.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/RxSwift.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/Rx.xcodeproj/xcshareddata/xcschemes/RxTest.xcscheme b/Rx.xcodeproj/xcshareddata/xcschemes/RxTest.xcscheme
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Scheme
-   LastUpgradeVersion = "1500"
+   LastUpgradeVersion = "1410"
    version = "1.3">
    <BuildAction
       parallelizeBuildables = "YES"

diff --git a/RxSwift/ObservableType.swift b/RxSwift/ObservableType.swift
@@ -39,7 +39,7 @@ extension ObservableType {
     /// Default implementation of converting `ObservableType` to `Observable`.
     public func asObservable() -> Observable<Element> {
         // temporary workaround
-        //return Observable.create(subscribe: self.subscribe)
+        // return Observable.create(subscribe: self.subscribe)
         Observable.create { o in self.subscribe(o) }
     }
 }
diff --git a/RxSwift/Observables/Amb.swift b/RxSwift/Observables/Amb.swift
@@ -100,7 +100,7 @@ final private class AmbSink<Observer: ObserverType>: Sink<Observer> {
         let subscription2 = SingleAssignmentDisposable()
         let disposeAll = Disposables.create(subscription1, subscription2)
 
-        let forwardEvent = { (o: AmbObserverType, event: Event<Element>) -> Void in
+        let forwardEvent = { (_: AmbObserverType, event: Event<Element>) -> Void in
             self.forwardOn(event)
             if event.isStopEvent {
                 self.dispose()