Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve batched merkle tree test coverage #1507

Merged
merged 6 commits into from
Jan 23, 2025
Merged

chore: improve batched merkle tree test coverage #1507

merged 6 commits into from
Jan 23, 2025

Conversation

ananas-block
Copy link
Contributor

@ananas-block ananas-block commented Jan 21, 2025 •
edited
Loading

CU improvements:

  • state tree from account info: 276 CU improvement, 822 CU → 546 CU
  • output queue from account info: 290 CU improvement for one deserialization, 909 CU → 619 CU
  1. MerkleTreeAccount & QueueAccount replace vectors with arrays of size 2
  2. light-zero-copy reduce number of casts by casting vec metadata as array instead of separate values

@ananas-block ananas-block marked this pull request as ready for review January 22, 2025 18:43
@ananas-block ananas-block force-pushed the jorrit/chore-batched-merkle-tree-add-testcoverage branch 2 times, most recently from 4db117c to 9e6af79 Compare January 22, 2025 19:18
@ananas-block ananas-block force-pushed the jorrit/chore-batched-merkle-tree-add-testcoverage branch from 9e6af79 to 355925a Compare January 22, 2025 22:12
@ananas-block ananas-block force-pushed the jorrit/chore-batched-merkle-tree-add-testcoverage branch from 674c689 to 983623d Compare January 23, 2025 03:37
SwenSchaeferjohann
SwenSchaeferjohann approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@SwenSchaeferjohann SwenSchaeferjohann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm overall!

@ananas-block ananas-block force-pushed the jorrit/chore-batched-merkle-tree-add-testcoverage branch from 983623d to d437a41 Compare January 23, 2025 16:06
@ananas-block ananas-block merged commit dfc2ef8 into main Jan 23, 2025
24 checks passed
@ananas-block ananas-block deleted the jorrit/chore-batched-merkle-tree-add-testcoverage branch January 23, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwenSchaeferjohann SwenSchaeferjohann SwenSchaeferjohann approved these changes

@sergeytimoshin sergeytimoshin Awaiting requested review from sergeytimoshin sergeytimoshin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ananas-block @SwenSchaeferjohann