chore: bump cli version and add .npmignore #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
reviewed
Sep 30, 2024
| @@ -0,0 +1 @@ | |||
| bin/cargo-generate | |||
There was a problem hiding this comment.
we include all files in bin/ on purpose excluding cargo-generate
There was a problem hiding this comment.
actually you are right we should download everything by release tag the way it is right now this is a setup for disaster because by including bin/* we include latest build instead of releases of all programs and prover binaries
There was a problem hiding this comment.
I would like to do that in a separate pr though
There was a problem hiding this comment.
I would like to do that in a separate pr though
That's fine. We also need to make sure that the download mechanism works properly for prover and the others.
sergeytimoshin
approved these changes
Sep 30, 2024
ananas-block
deleted the
jorrit/chore-bump-cli-version-add-npmignore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue:
cargo-generatebin was bundled accidentally with release of cli this way the cli release0.18.0init command only works for mac os without manually removing the bundledcargo-generatebinaryChanges:
0.18.1.npmignorefile to remove the footgun of accidentally bundlingcargo-generate