Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Correct python version support metadata #1367

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

ethanwharris
Copy link
Collaborator

What does this PR do?

Fixes #1351

Note: The README won't update until we make a release

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@ethanwharris ethanwharris added the bug / fix Something isn't working label Jun 29, 2022
@ethanwharris ethanwharris added this to the 0.8.0 milestone Jun 29, 2022
@ethanwharris ethanwharris requested a review from Borda as a code owner June 29, 2022 13:55
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #1367 (29845ea) into master (0ae31c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1367   +/-   ##
=======================================
  Coverage   91.56%   91.56%           
=======================================
  Files         286      286           
  Lines       12814    12814           
=======================================
  Hits        11733    11733           
  Misses       1081     1081           
Flag Coverage Δ
unittests 91.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/model.py 92.51% <0.00%> (-1.37%) ⬇️
flash/text/question_answering/collate.py 97.64% <0.00%> (+2.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ae31c8...29845ea. Read the comment docs.

@ethanwharris ethanwharris merged commit e380b02 into master Jun 29, 2022
@ethanwharris ethanwharris deleted the bgufix/correct_python_support branch June 29, 2022 15:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ModuleNotFoundError: No module named 'icevision.backbones'
1 participant