-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor dcgan-import fix #921
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I checked the resnet download link its working :). I am taking a look at the retinanet tests. More or less it looks like an azure pipeline issue :( |
that seems to be unrelated... that is fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Atharva-Phatak Thank you for working on this!
Could you also update the docstring so that it uses the new way of specifying the accelerator?
https://github.com/Lightning-AI/lightning-bolts/blob/43f869ff3f09c2d967d850525d0723da51db48b6/pl_bolts/models/gans/dcgan/dcgan_module.py#L30
Trainer(accelerator="gpu", devices=2)
@Atharva-Phatak FYI, the failure of the test case is being investigated by @rohitgr7 via #910. |
Updated the docstring. Thanks for the letting me know :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Atharva-Phatak! LGTM!
What does this PR do?
Reviews DCGAN implementations in #839.
Though GAN implementation is very specific. GANS module requires some discussion on how the package should be structured.
Part of #839
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃