Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update workers - hanging tests #521

Merged
merged 10 commits into from
Jan 18, 2021
Merged

update workers - hanging tests #521

merged 10 commits into from
Jan 18, 2021

Conversation

Borda
Copy link
Member

@Borda Borda commented Jan 17, 2021

What does this PR do?

seems some tests are failing because of too many workers

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added the fix fixing issues... label Jan 17, 2021
@pep8speaks
Copy link

pep8speaks commented Jan 17, 2021

Hello @Borda! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-18 00:03:47 UTC

@github-actions github-actions bot added the model label Jan 17, 2021
@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #521 (7b389b9) into master (8191725) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #521   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files         105      105           
  Lines        6121     6121           
=======================================
  Hits         4833     4833           
  Misses       1288     1288           
Flag Coverage Δ
cpu 25.66% <0.00%> (ø)
pytest 25.66% <0.00%> (ø)
unittests 78.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...bolts/models/self_supervised/amdim/amdim_module.py 96.73% <ø> (ø)
...l_bolts/models/self_supervised/byol/byol_module.py 82.92% <ø> (ø)
pl_bolts/models/regression/logistic_regression.py 95.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8191725...6843861. Read the comment docs.

@Borda Borda added the Priority High priority task label Jan 17, 2021
@Borda Borda marked this pull request as ready for review January 17, 2021 23:02
@Borda Borda changed the title add workers - hanging tests update workers - hanging tests Jan 17, 2021
@Borda Borda merged commit 99232c3 into master Jan 18, 2021
@Borda Borda deleted the fix/hanging branch January 18, 2021 00:09
@Borda Borda added this to the v0.3 milestone Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix fixing issues... model Priority High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants