This repository has been archived by the owner on Mar 7, 2023. It is now read-only.
Protobuf version fix to allow installing new Lightning #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes protobuf contradiction with Lightning.
What we have now:
protobuf
dependency to be< 3.20
here: Force protobuf dependency < 3.20. tensorflow/tensorboard#5726, this is included intensorboard==2.9.1
.=> due to this protobuf versions contradiction and due to we don’t restrict Lightning version in apps requirements (we'd get an error), pip installs very old
Lightning
version:lightning==2022.7.18
andlightning-app==0.5.7
.For Lightning main repo, the problem was addressed here: Lightning-AI/pytorch-lightning#13259.
Does your PR introduce any breaking changes? If yes, please list them.
No, this is just a fix.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read
the review guidelines. In short, see the
following bullet-list:
Did you have fun?
That was a great python dependencies puzzle! 😄