Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated compute_on_step in Regression #967

Conversation

vumichien
Copy link
Contributor

@vumichien vumichien commented Apr 20, 2022

What does this PR do?

Part of #956

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #967 (1fe59e5) into master (23b2e45) will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #967   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         177    177           
  Lines        7509   7509           
=====================================
- Hits         7137   7124   -13     
- Misses        372    385   +13     

@Borda Borda added the refactoring refactoring and code health label Apr 20, 2022
@Borda Borda added this to the v0.9 milestone Apr 20, 2022
@Borda Borda mentioned this pull request Apr 20, 2022
9 tasks
@mergify mergify bot added the ready label Apr 20, 2022
@Borda Borda enabled auto-merge (squash) April 20, 2022 08:36
@Borda Borda merged commit 10b3a85 into Lightning-AI:master Apr 20, 2022
@vumichien vumichien deleted the refactoring/remove_compute_on_step_regression branch April 20, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready refactoring refactoring and code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants