Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_num_classes in jaccard_index #914

Merged
merged 11 commits into from
Mar 31, 2022
Merged

Conversation

rusty1s
Copy link
Contributor

@rusty1s rusty1s commented Mar 25, 2022

What does this PR do?

This PR removes the get_num_classes call in jaccard_index. This call is no longer required since the num_classes argument of jaccard_index is now mandatory. Since get_num_classes is not used anywhere else, I removed the function completely.

Before submitting

  • Was this discussed/approved via Slack? (discussed with @SkafteNicki and @Borda)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #914 (ce147fa) into master (712a81b) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #914   +/-   ##
=====================================
- Coverage      95%    95%   -0%     
=====================================
  Files         173    173           
  Lines        7344   7332   -12     
=====================================
- Hits         6976   6962   -14     
- Misses        368    370    +2     

@Borda Borda added the bug / fix Something isn't working label Mar 25, 2022
@Borda Borda added this to the v0.8 milestone Mar 25, 2022
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding a record to changelog? 🐰

@rusty1s
Copy link
Contributor Author

rusty1s commented Mar 25, 2022

done :)

@Borda Borda enabled auto-merge (squash) March 25, 2022 16:53
@mergify mergify bot added the ready label Mar 25, 2022
@mergify mergify bot removed the ready label Mar 28, 2022
@rusty1s
Copy link
Contributor Author

rusty1s commented Mar 28, 2022

What's the reason for the failing CI? Anything I can do about it?

@Borda
Copy link
Member

Borda commented Mar 28, 2022

What's the reason for the failing CI? Anything I can do about it?

well, atm seems there is some connection error so nothing related to this PR :/

@mergify mergify bot added the ready label Mar 31, 2022
@Borda Borda merged commit c537c9b into Lightning-AI:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants