Better support for classwise logging #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
edenlightning,
Borda,
justusschock,
ananyahjha93,
tchaton,
ethanwharris and
SeanNaren
as code owners
Codecov Report
@@ Coverage Diff @@
## master #832 +/- ##
=====================================
- Coverage 95% 95% -0%
=====================================
Files 166 167 +1
Lines 6864 6896 +32
=====================================
+ Hits 6522 6552 +30
- Misses 342 344 +2 |
Borda
reviewed
Feb 10, 2022
Borda
reviewed
Feb 10, 2022
Co-authored-by: Jirka Borovec <[email protected]>
justusschock
approved these changes
Feb 10, 2022
| """Test wrapper in combination with metric collection.""" | ||
| labels = ["horse", "fish", "cat"] | ||
| metric = MetricCollection( | ||
| { |
There was a problem hiding this comment.
but here it won't share states, right?
There was a problem hiding this comment.
You are right. That is common problem for all the wrappers because we assume that states are not nested when trying to figure out the compute groups.
I can try to come up with a general solution for this problem
There was a problem hiding this comment.
Can we maybe have a property that kind of forwards the states of the wrapped metrics?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #815
Implement a
ClasswiseWrapperthat makes it easier to log classification metrics that return multiple values.Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃