Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune deprecated: audio #805

Merged
merged 7 commits into from
Jan 27, 2022
Merged

Prune deprecated: audio #805

merged 7 commits into from
Jan 27, 2022

Conversation

ashutoshml
Copy link
Contributor

@ashutoshml ashutoshml commented Jan 27, 2022 •
edited
Loading

What does this PR do?

Fixes part of #771

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #805 (c2273b4) into master (c6020e4) will decrease coverage by 8%.
The diff coverage is 100%.

❗ Current head c2273b4 differs from pull request most recent head 34b5550. Consider uploading reports for the commit 34b5550 to get more accurate results

@@          Coverage Diff           @@
##           master   #805    +/-   ##
======================================
- Coverage      91%    82%    -8%     
======================================
  Files         171    167     -4     
  Lines        6926   6833    -93     
======================================
- Hits         6274   5629   -645     
- Misses        652   1204   +552

@ashutoshml ashutoshml marked this pull request as ready for review January 27, 2022 07:35
@ashutoshml ashutoshml mentioned this pull request Jan 27, 2022
Closed
5 tasks
@Borda Borda added the enhancement New feature or request label Jan 27, 2022
@Borda Borda added this to the v0.8 milestone Jan 27, 2022
@mergify mergify bot added the ready label Jan 27, 2022
@Borda Borda enabled auto-merge (squash) January 27, 2022 10:55
auto-merge was automatically disabled January 27, 2022 20:24

Pull Request is not mergeable

@Borda Borda disabled auto-merge January 27, 2022 20:24
@Borda Borda merged commit 64e80c0 into Lightning-AI:master Jan 27, 2022
@mergify mergify bot removed the ready label Jan 27, 2022
@ashutoshml ashutoshml deleted the pruneaudio branch January 28, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SkafteNicki SkafteNicki SkafteNicki approved these changes

@Borda Borda Borda approved these changes

@ananyahjha93 ananyahjha93 Awaiting requested review from ananyahjha93

@edenlightning edenlightning Awaiting requested review from edenlightning

@ethanwharris ethanwharris Awaiting requested review from ethanwharris

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashutoshml @Borda @SkafteNicki