Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MetricCollection compatibility with torch.jit.script #2813

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Oct 31, 2024

What does this PR do?

Fixes #2812

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2813.org.readthedocs.build/en/2813/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Oct 31, 2024
@SkafteNicki SkafteNicki added this to the v1.5.x milestone Oct 31, 2024
@SkafteNicki SkafteNicki self-assigned this Oct 31, 2024
@mergify mergify bot removed the has conflicts label Oct 31, 2024
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (5d6bb56) to head (15b9f17).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2813   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         344     344           
  Lines       18823   18824    +1     
======================================
+ Hits        12970   12971    +1     
  Misses       5853    5853           

@mergify mergify bot added the ready label Oct 31, 2024
@Borda Borda merged commit abdd2c4 into master Oct 31, 2024
53 of 55 checks passed
@Borda Borda deleted the bugfix/collection_jit branch October 31, 2024 11:58
Borda pushed a commit that referenced this pull request Nov 7, 2024
Borda pushed a commit that referenced this pull request Nov 7, 2024
Borda pushed a commit that referenced this pull request Nov 7, 2024
Borda pushed a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MetricsCollection is not Pytorch JIT-able due to its metric_state property
2 participants