Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: Torch 2.5.0 #2790

Merged
merged 12 commits into from
Oct 21, 2024
Merged

bump: Torch 2.5.0 #2790

merged 12 commits into from
Oct 21, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Oct 18, 2024

What does this PR do?

aligning with the recent release of PT 2.5

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2790.org.readthedocs.build/en/2790/

@Borda Borda enabled auto-merge (squash) October 18, 2024 20:50
@Borda
Copy link
Member Author

Borda commented Oct 18, 2024

FAILED unittests/bases/test_collections.py::test_metric_collection_prefix_postfix_args[None-None] - AssertionError: assert False
 +  where False = isinstance(dict_keys(['DummyMetricSum', 'DummyMetricDiff']), <class 'odict_keys'>)
 +    where dict_keys(['DummyMetricSum', 'DummyMetricDiff']) = keys(keep_base=True)
 +      where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_\n).keys
 +    and   <class 'odict_keys'> = type(odict_keys(['new_prefix_DummyMetricSum', 'new_prefix_DummyMetricDiff']))
 +      where odict_keys(['new_prefix_DummyMetricSum', 'new_prefix_DummyMetricDiff']) = keys(keep_base=False)
 +        where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_\n).keys
FAILED unittests/bases/test_collections.py::test_metric_collection_prefix_postfix_args[prefix_-None] - AssertionError: assert False
 +  where False = isinstance(dict_keys(['DummyMetricSum', 'DummyMetricDiff']), <class 'odict_keys'>)
 +    where dict_keys(['DummyMetricSum', 'DummyMetricDiff']) = keys(keep_base=True)
 +      where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_\n).keys
 +    and   <class 'odict_keys'> = type(odict_keys(['new_prefix_DummyMetricSum', 'new_prefix_DummyMetricDiff']))
 +      where odict_keys(['new_prefix_DummyMetricSum', 'new_prefix_DummyMetricDiff']) = keys(keep_base=False)
 +        where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_\n).keys
FAILED unittests/bases/test_collections.py::test_metric_collection_prefix_postfix_args[None-_postfix] - AssertionError: assert False
 +  where False = isinstance(dict_keys(['DummyMetricSum', 'DummyMetricDiff']), <class 'odict_keys'>)
 +    where dict_keys(['DummyMetricSum', 'DummyMetricDiff']) = keys(keep_base=True)
 +      where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_,\n  postfix=_postfix\n).keys
 +    and   <class 'odict_keys'> = type(odict_keys(['new_prefix_DummyMetricSum_postfix', 'new_prefix_DummyMetricDiff_postfix']))
 +      where odict_keys(['new_prefix_DummyMetricSum_postfix', 'new_prefix_DummyMetricDiff_postfix']) = keys(keep_base=False)
 +        where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_,\n  postfix=_postfix\n).keys
FAILED unittests/bases/test_collections.py::test_metric_collection_prefix_postfix_args[prefix_-_postfix] - AssertionError: assert False
 +  where False = isinstance(dict_keys(['DummyMetricSum', 'DummyMetricDiff']), <class 'odict_keys'>)
 +    where dict_keys(['DummyMetricSum', 'DummyMetricDiff']) = keys(keep_base=True)
 +      where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_,\n  postfix=_postfix\n).keys
 +    and   <class 'odict_keys'> = type(odict_keys(['new_prefix_DummyMetricSum_postfix', 'new_prefix_DummyMetricDiff_postfix']))
 +      where odict_keys(['new_prefix_DummyMetricSum_postfix', 'new_prefix_DummyMetricDiff_postfix']) = keys(keep_base=False)
 +        where keys = MetricCollection(\n  (DummyMetricSum): DummyMetricSum()\n  (DummyMetricDiff): DummyMetricDiff(),\n  prefix=new_prefix_,\n  postfix=_postfix\n).keys
FAILED unittests/wrappers/test_multitask.py::test_error_on_wrong_keys - AssertionError: Regex pattern did not match.
 Regex: "Expected\\ arguments\\ `task_preds`\\ and\\ `task_targets`\\ to\\ have\\ the\\ same\\ keys\\ as\\ the\\ wrapped\\ `task_metrics`\\.\\ Found\\ task_preds\\.keys\\(\\)\\ =\\ dict_keys\\(\\['Classification'\\]\\),\\ task_targets\\.keys\\(\\)\\ =\\ dict_keys\\(\\['Classification',\\ 'Regression'\\]\\)\\ and\\ self\\.task_metrics\\.keys\\(\\)\\ =\\ odict_keys\\(\\['Classification',\\ 'Regression'\\]\\)"
 Input: "Expected arguments `task_preds` and `task_targets` to have the same keys as the wrapped `task_metrics`. Found task_preds.keys() = dict_keys(['Classification']), task_targets.keys() = dict_keys(['Classification', 'Regression']) and self.task_metrics.keys() = dict_keys(['Classification', 'Regression'])"

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69%. Comparing base (346bcdc) to head (d77942c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2790   +/-   ##
======================================
  Coverage      69%     69%           
======================================
  Files         336     336           
  Lines       18215   18215           
======================================
  Hits        12494   12494           
  Misses       5721    5721           

@SkafteNicki
Copy link
Member

Failing tests most likely related to #2789

.github/workflows/ci-tests.yml Outdated Show resolved Hide resolved
@Borda
Copy link
Member Author

Borda commented Oct 20, 2024

Failing tests most likely related to #2789

I see... @SkafteNicki how about merging this with failing tests for 2.5 but enabling the testing so @bfolie can send a PR which will be validated straight away :)

@Borda Borda added enhancement New feature or request Priority Critical task/issue test / CI testing or CI labels Oct 20, 2024
@SkafteNicki
Copy link
Member

Failing tests most likely related to #2789

I see... @SkafteNicki how about merging this with failing tests for 2.5 but enabling the testing so @bfolie can send a PR which will be validated straight away :)

I prefer the other PR is open before we merge this so we can instantly evaluate if anything else is missing. Else let me check locally if anything else is missing

@Borda Borda disabled auto-merge October 21, 2024 18:29
@Borda Borda merged commit 0e090b4 into master Oct 21, 2024
58 of 65 checks passed
@Borda Borda deleted the bump/PT-2.5 branch October 21, 2024 19:42
Borda added a commit that referenced this pull request Oct 22, 2024
(cherry picked from commit 0e090b4)
Borda added a commit that referenced this pull request Oct 22, 2024
(cherry picked from commit 0e090b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority Critical task/issue test / CI testing or CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants