Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: adding PESQ example to gallery #2755

Merged
merged 15 commits into from
Oct 15, 2024
Merged

docs: adding PESQ example to gallery #2755

merged 15 commits into from
Oct 15, 2024

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 18, 2024

What does this PR do?

adding another sample

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2755.org.readthedocs.build/en/2755/

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70%. Comparing base (a8cbae7) to head (a971d3c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2755   +/-   ##
======================================
  Coverage      70%     70%           
======================================
  Files         336     336           
  Lines       18231   18231           
======================================
  Hits        12707   12707           
  Misses       5524    5524           

@SkafteNicki
Copy link
Member

@Borda what is missing here?

@Borda
Copy link
Member Author

Borda commented Oct 10, 2024

what is missing here?

I was not sure if the story is rich enough

@Borda Borda marked this pull request as ready for review October 10, 2024 11:12
@Borda Borda added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 10, 2024
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 10, 2024
@Borda Borda requested a review from baskrahmer October 15, 2024 08:36
Copy link
Member

@SkafteNicki SkafteNicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda just an idea

examples/audio/pesq.py Outdated Show resolved Hide resolved
examples/audio/pesq.py Outdated Show resolved Hide resolved
examples/audio/pesq.py Outdated Show resolved Hide resolved
Co-authored-by: Nicki Skafte Detlefsen <[email protected]>
@Borda Borda requested a review from SkafteNicki October 15, 2024 09:50
@Borda Borda merged commit 6377aa5 into master Oct 15, 2024
55 of 59 checks passed
@Borda Borda deleted the docs/pesq branch October 15, 2024 18:33
@mergify mergify bot added the ready label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants