Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional color map parameter for confusion matrix #2512

Conversation

randombenj
Copy link
Contributor

@randombenj randombenj commented Apr 22, 2024

What does this PR do?

This change allows to specify a cmap for the confusion matrix, making the matrix (IMO) more readable.
Here is an example specifying cmap="Blues":

image

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2512.org.readthedocs.build/en/2512/

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Merging #2512 (1c1a955) into master (af32fd0) will decrease coverage by 0%.
The diff coverage is 29%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #2512   +/-   ##
======================================
- Coverage      69%     69%   -0%     
======================================
  Files         313     313           
  Lines       17596   17598    +2     
======================================
+ Hits        12146   12147    +1     
- Misses       5450    5451    +1     

@mergify mergify bot added the ready label Apr 22, 2024
@SkafteNicki SkafteNicki added this to the v1.4.0 milestone Apr 22, 2024
@SkafteNicki SkafteNicki added the enhancement New feature or request label Apr 22, 2024
@SkafteNicki SkafteNicki enabled auto-merge (squash) April 23, 2024 08:58
@mergify mergify bot removed the ready label Apr 23, 2024
@SkafteNicki SkafteNicki merged commit 3d52192 into Lightning-AI:master Apr 23, 2024
62 checks passed
@mergify mergify bot added the ready label Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants