Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise error in MeanAveragePrecision if too little/many detection are provided for pycocotools backend #2219

Merged
merged 11 commits into from
Nov 28, 2023
Merged

Raise error in MeanAveragePrecision if too little/many detection are provided for pycocotools backend #2219

merged 11 commits into from
Nov 28, 2023

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Nov 17, 2023 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #2218

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

📚 Documentation preview 📚: https://torchmetrics--2219.org.readthedocs.build/en/2219/

@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Nov 17, 2023
@SkafteNicki SkafteNicki added this to the v1.2.x milestone Nov 17, 2023
@SkafteNicki SkafteNicki mentioned this pull request Nov 17, 2023
Closed
@SkafteNicki SkafteNicki self-assigned this Nov 17, 2023
@mergify mergify bot removed the has conflicts label Nov 25, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2023 •
edited
Loading

Codecov Report

Merging #2219 (1f2c561) into master (46dfa42) will decrease coverage by 50%.
The diff coverage is 100%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #2219     +/-   ##
========================================
- Coverage      87%     37%    -50%     
========================================
  Files         293     293             
  Lines       16432   16434      +2     
========================================
- Hits        14268    6024   -8244     
- Misses       2164   10410   +8246

@Borda Borda enabled auto-merge (squash) November 25, 2023 18:16
@mergify mergify bot added the ready label Nov 25, 2023
@Borda Borda disabled auto-merge November 28, 2023 16:02
@Borda Borda merged commit 56c0fdf into master Nov 28, 2023
28 of 37 checks passed
@Borda Borda deleted the error_on_max_det_thresholds branch November 28, 2023 16:03
Borda pushed a commit that referenced this pull request Nov 30, 2023
@SkafteNicki @Borda
Raise error in MeanAveragePrecision if too little/many detection ar…
12c2344 
…e provided for `pycocotools` backend (#2219)

(cherry picked from commit 56c0fdf)
Borda pushed a commit that referenced this pull request Dec 1, 2023
@SkafteNicki @Borda
Raise error in MeanAveragePrecision if too little/many detection ar…
9acafd1 
…e provided for `pycocotools` backend (#2219)

(cherry picked from commit 56c0fdf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

@stancld stancld Awaiting requested review from stancld stancld is a code owner

Assignees

@SkafteNicki SkafteNicki

Labels
bug / fix Something isn't working ready topic: Detect
Projects
None yet
Milestone
v1.2.x
Development

Successfully merging this pull request may close these issues.

torchmetrics.detection.mean_ap.MeanAveragePrecision bug if en(max_detection_thresholds)<3
3 participants
@SkafteNicki @Borda @justusschock